linux-kernel - Re: [PATCH v2] selftests: tpm2: create a dedicated .gitignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7AG8K6T8KRI.LZFD4J6OFGGZ@kernel.org>
Date: Fri, 24 Jan 2025 18:37:47 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Khaled Elnaggar" <khaledelnaggarlinux@...il.com>, <peterhuewe@....de>,
 <jgg@...pe.ca>, <shuah@...nel.org>
Cc: <linux-kernel-mentees@...r.kernel.org>,
 <linux-integrity@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] selftests: tpm2: create a dedicated .gitignore

On Fri Jan 24, 2025 at 4:35 PM EET, Khaled Elnaggar wrote:
> On 1/23/25 11:47 AM, Jarkko Sakkinen wrote: 
> > Why?
>
> Sorry I should have included v1 in the thread but I am still
> new to the LKML process.

No worries, relax, it was just  a one wonder question :-)

>
> Basically tpm2 selftests have 2 leftover log files after running
> (namely AsyncTest.log and SpaceTest.log). Only SpaceTest.log
> is in selftests/.gitignore while AsyncTest.log appears untracked
> with git status.
>
> To solve this, one could either append AsyncTest.log to 
> selftests/.gitignore or create a dedicated .gitignore for 
> the tpm2 subsystem tests. The 2nd approach is better in order
> to not clutter selftests/.gitignore and keep tpm2 isolated.
>
> Shuah actually suggested the 2nd approach in reply to v1.
>
> Would you like me to resubmit this patch with a clearer message?
> Or include v1 in the thread?

Yep, please do, your rationale makes sense, just write it down
to the commit message, and that's all I'm asking for.

>
> Thanks
> Khaled

BR, Jarkko