linux-kernel - Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <915e19a9-204c-4a22-b132-6ae5fac3e270@bytedance.com>
Date: Fri, 24 Jan 2025 10:43:38 +0800
From: Qi Zheng <zhengqi.arch@...edance.com>
To: Alexander Gordeev <agordeev@...ux.ibm.com>
Cc: Kevin Brodsky <kevin.brodsky@....com>,
 Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, linux-mm@...ck.org,
 linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade



On 2025/1/24 00:03, Alexander Gordeev wrote:
> Commit 78966b550289 ("s390: pgtable: add statistics for PUD and P4D
> level page table") misses the call to pagetable_p4d_ctor() against
> a newly allocated P4D table in crst_table_upgrade();
> 
> Commit 68c601de75d8 ("mm: introduce ctor/dtor at PGD level") misses
> the call to pagetable_pgd_ctor() against a newly allocated PGD and
> the call to pagetable_dtor() against a newly allocated P4D that is
> about to be freed on crst_table_upgrade() PGD upgrade fail path.
> 
> The missed constructors and destructor break (at least) the page
> table accounting when a process memory space is upgraded.
> 
> Reported-by: Heiko Carstens <hca@...ux.ibm.com>
> Closes: https://lore.kernel.org/all/20250122074954.8685-A-hca@linux.ibm.com/
> Suggested-by: Heiko Carstens <hca@...ux.ibm.com>
> Fixes: 78966b550289 ("s390: pgtable: add statistics for PUD and P4D level page table")
> Fixes: 68c601de75d8 ("mm: introduce ctor/dtor at PGD level")
> Signed-off-by: Alexander Gordeev <agordeev@...ux.ibm.com>
> ---
> The patch is against:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git	next-20250123
>    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm			mm-stable
> ---
>   arch/s390/mm/pgalloc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 

Acked-by: Qi Zheng <zhengqi.arch@...edance.com>

Thanks!