linux-kernel - Re: [PATCH v4 0/2] hwmon:(ina238)Add support for SQ52206

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7c3d35a-e8a5-40ee-9b47-c22d87fa7f71@roeck-us.net>
Date: Fri, 24 Jan 2025 21:01:36 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Wenliang Yan <wenliang202407@....com>, christophe.jaillet@...adoo.fr,
 jdelvare@...e.com
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] hwmon:(ina238)Add support for SQ52206

On 1/24/25 19:02, Wenliang Yan wrote:
> Add support for Silergy i2c power monitor SQ52206 to the ina238
> driver as those two are similar.
> 
> Signed-off-by: Wenliang Yan <wenliang202407@....com>
> ---
> 
> Add new chip SQ52206, the datasheet depends on
> https://us1.silergy.com/cloud/index/uniqid/676b659b4a503
> The password is fx6NEe.
> 
> Changes in v4:
> - addressed various review comments.
> - Link to v3: https://lore.kernel.org/linux-hwmon/20250117082017.688212-1-wenliang202407@163.com/
> 

Your "change logs" are equivalent to "made changes" and completely pointless.
As consequence, I'll only handle your patches if and when I have nothing else
to review since I'll have to figure out myself what you changed and if you
implemented the feedback. I don't really hve time for that, so please do not
expect that I'll apply this series anytime soon.

Guenter

> Changes in v3:
> - addressed various review comments.
> - Link to v2: https://lore.kernel.org/linux-hwmon/20250113035023.365697-1-wenliang202407@163.com/
> 
> Changes in v2:
> - Explain why sq52206 compatibility has been added to ina2xx.yaml.
> - addressed various review comments
> - Link to v1: https://lore.kernel.org/linux-hwmon/20241224063559.391061-1-wenliang202407@163.com/
> 
> Wenliang Yan (2):
>    dt-bindings:Add SQ52206 to ina2xx devicetree bindings
>    hwmon:(ina238)Add support for SQ52206
> 
>   .../devicetree/bindings/hwmon/ti,ina2xx.yaml  |   4 +
>   Documentation/hwmon/ina238.rst                |  15 ++
>   drivers/hwmon/ina238.c                        | 209 +++++++++++++++---
>   3 files changed, 195 insertions(+), 33 deletions(-)
>