linux-kernel - Re: [PATCH v2] iio: adc: ad7192: fix channel select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250125122222.22e3285a@jic23-huawei>
Date: Sat, 25 Jan 2025 12:22:22 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>, Alisa-Dariana Roman
 <alisa.roman@...log.com>, linux-iio@...r.kernel.org, Nuno Sá
 <nuno.sa@...log.com>
Subject: Re: [PATCH v2] iio: adc: ad7192: fix channel select

On Fri, 24 Jan 2025 16:07:03 +0100
Markus Burri <markus.burri@...com> wrote:

> Channel configuration doesn't work as expected.
> For FIELD_PREP the bit mask is needed and not the bit number.
> 
> Fixes: 874bbd1219c7 ("iio: adc: ad7192: Use bitfield access macros")
needs to be part of the tags block.  Hence no blank line here.

I'll tidy that up whilst applying.  Applied and marked for stable.
Note I'll not push out my tree until I can rebase on rc1 after
next weekend as right now it would make a mess of linux-next.
> 
> Signed-off-by: Markus Burri <markus.burri@...com>
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> ---
>  drivers/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 1c87db0e0460..c4effe8429c8 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon
>  
>  	conf &= ~AD7192_CONF_CHAN_MASK;
>  	for_each_set_bit(i, scan_mask, 8)
> -		conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i);
> +		conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i));
>  
>  	ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf);
>  	if (ret < 0)
> 
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04