linux-kernel - Re: [PATCH] firmware: qcom: uefisecapp: fix efivars registration race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f838ff5d-a80c-413b-b32b-766ec4667892@gmail.com>
Date: Sat, 25 Jan 2025 17:32:15 +0100
From: Maximilian Luz <luzmaximilian@...il.com>
To: Johan Hovold <johan+linaro@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>,
 Elliot Berman <quic_eberman@...cinc.com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: uefisecapp: fix efivars registration race

On 1/20/25 4:10 PM, Johan Hovold wrote:
> Since the conversion to using the TZ allocator, the efivars service is
> registered before the memory pool has been allocated, something which
> can lead to a NULL-pointer dereference in case of a racing EFI variable
> access.
> 
> Make sure that all resources have been set up before registering the
> efivars.
> 
> Fixes: 6612103ec35a ("firmware: qcom: qseecom: convert to using the TZ allocator")
> Cc: stable@...r.kernel.org	# 6.11
> Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---

Looks good to me.

Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>