linux-kernel - Re: [PATCH net v2] ptp: Properly handle compat ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4b4188d3-3ac9-465b-9e74-703a5d70588e@app.fastmail.com>
Date: Sat, 25 Jan 2025 18:04:45 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 "Richard Cochran" <richardcochran@...il.com>,
 "Andrew Lunn" <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>,
 "Anna-Maria Gleixner" <anna-maria@...utronix.de>,
 "Frederic Weisbecker" <frederic@...nel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>, "John Stultz" <jstultz@...gle.com>,
 "John Stultz" <john.stultz@...aro.org>
Cc: Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
 "Cyrill Gorcunov" <gorcunov@...il.com>
Subject: Re: [PATCH net v2] ptp: Properly handle compat ioctls

On Sat, Jan 25, 2025, at 10:28, Thomas Weißschuh wrote:
> Pointer arguments passed to ioctls need to pass through compat_ptr() to
> work correctly on s390; as explained in Documentation/driver-api/ioctl.rst.
> Detect compat mode at runtime and call compat_ptr() for those commands
> which do take pointer arguments.
>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Link: 
> https://lore.kernel.org/lkml/1ba5d3a4-7931-455b-a3ce-85a968a7cb10@app.fastmail.com/
> Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp 
> clocks.")
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Reviewed-by: Arnd Bergmann <arnd@...db.de>