[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <D7BFCPQPV9W0.1C7B7VU5Y4FCL@gmail.com>
Date: Sat, 25 Jan 2025 21:08:51 +0100
From: "Javier Carrasco" <javier.carrasco.cruz@...il.com>
To: "Matti Vaittinen" <mazziesaccount@...il.com>, "Jonathan Cameron"
<jic23@...nel.org>, "Lars-Peter Clausen" <lars@...afoo.de>, "Rishi Gupta"
<gupt21@...il.com>
Cc: <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Jonathan
Cameron" <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 3/4] iio: gts-helper: export iio_gts_get_total_gain()
On Fri Jan 24, 2025 at 9:12 AM CET, Matti Vaittinen wrote:
> On 19/01/2025 19:32, Javier Carrasco wrote:
> > Export this function in preparation for the fix in veml6030.c, where the
> > total gain can be used to ease the calculation of the processed value of
> > the IIO_LIGHT channel compared to acquiring the scale in NANO.
> >
> > Suggested-by: Matti Vaittinen <mazziesaccount@...il.com>
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
>
> Hi Javier,
>
> This is fine but could you please go the extra mile and add a doc to the
> function? I'd like to have kerneldoc for all exported functions.
>
Hi Matti,
Sure, I will add that for v3.
Thanks for your feedback and best regards,
Javier Carrasco
Powered by blists - more mailing lists