linux-kernel - Re: First kernel contribution, question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <72a1abd5-c5e7-4a4a-9c32-1d3a6014fc8e@csgroup.eu>
Date: Sat, 25 Jan 2025 20:52:04 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Jeremy Clifton <gservice341@...il.com>, mhiramat@...nel.org,
 akpm@...ux-foundation.org, mingo@...nel.org, ytcoode@...il.com,
 mcgrof@...nel.org, tj@...nel.org, tglx@...utronix.de, pmladek@...e.com,
 shijie@...amperecomputing.com, geert+renesas@...der.be,
 rrangel@...omium.org, linux-kernel@...r.kernel.org,
 Jeremy Dean <deaner92@...oo.com>,
 "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>
Subject: Re: First kernel contribution, question

Hi Jeremy,

Le 25/01/2025 à 18:47, Jeremy Clifton a écrit :
> 	
> 
> Hello, my name is Jeremy Clifton and I am just getting started with 
> linux kernel development and contributions. I have recently created a 
> patch and sent it out to your team.

Welcome. Please send plain text mails not html format.

> 
> After submitting my patch, *should I be able to see the patch on the 
> patchwork site*? I don't see one.

Your patch was well received but is only addressed to 
linux-kernel@...r.kernel.org and I don't think there is a patchwork for 
that list.

I know patchwork for powerpc list for modules list for network list etc 
... but not the general kernel list.

The patchworks I know are located at:
- https://patchwork.kernel.org/
- https://patchwork.ozlabs.org/

But your patch is visible and cleanly applies anyway using b4:

$ b4 shazam 20250125154139.7565-1-deaner92@...oo.com
Grabbing thread from 
lore.kernel.org/all/20250125154139.7565-1-deaner92@...oo.com/t.mbox.gz
Breaking thread to remove parents of 
20250125154139.7565-1-deaner92@...oo.com
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 1 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
   ✓ [PATCH] init: Unnecessary braces around single line statment.
   ---
   ✓ Signed: DKIM/yahoo.com
---
Total patches: 1
---
Application de  init: Unnecessary braces around single line statment.

> 
> I want to get this process right so that my contributions will go 
> through. I don't see it on the site. Am I doing something wrong?

The process is well documented at https://docs.kernel.org/

> 
> I edited the file at init/main.c to remove unnecessary braces on line 400.
> I could not find my patch on the patchwork site and this made me think 
> that I am starting in the wrong place.

Well, I'd suggest you to not send such trivial changes. Such changes are 
almost never taken as standelone. Cosmetic patches are usually 
considered when they are part of a wider series that does real changes 
at the same time.

I recommend you to spend your time on more interesting changes.


> 
>   Also, just saying 'hello'. I sent an email with the email address 
> 'deaner92@...oo.com <mailto:deaner92@...oo.com>'.
> 
> Thank you all for your contributions and your time in reading over this 
> email. Any guidance is gladly appreciated.

Christophe