linux-kernel - Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5aMrXwnmEXxKWkC@vmi2410184.contaboserver.net>
Date: Sun, 26 Jan 2025 20:27:41 +0100
From: Jeremy Dean <deaner92@...oo.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: marcel@...tmann.org, luiz.dentz@...il.com,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: Remove unnecessary braces around single line
 statement

Dear Paul,

I have changed the subject. 

Fixes: Coding style, unnecessary braces

On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote:
> Dear Jeremy,
> 
> 
> Thank you for your patch. Could you please make the summary/title a
> statement, and remove the dot/period at the end:
> 
> Bluetooth: Remove unnecessary braces around single line statement
> 
> Am 25.01.25 um 17:58 schrieb deaner92@...oo.com:
> > From: Jeremy Clifton <deaner92@...oo.com>
> > 
> > Warning found with checkpatch.pl script. Removed unnecessary braces.
> 
> I’d use imperative mood for the second sentence:
> 
> Remove unnecessary braces.
> 
> Also please add a Fixes: tag.
> 
> > Signed-off-by: Jeremy Clifton <deaner92@...oo.com>
> > ---
> >   drivers/bluetooth/bfusb.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> > index cab93935cc7f..0d6ad50da046 100644
> > --- a/drivers/bluetooth/bfusb.c
> > +++ b/drivers/bluetooth/bfusb.c
> > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
> >   			buf   += 3;
> >   		}
> > -		if (count < len) {
> > +		if (count < len)
> >   			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
> > -		}
> >   		if ((hdr & 0xe1) == 0xc1)
> >   			bfusb_recv_block(data, hdr, buf, len);
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul