linux-kernel - Re: [PATCH] bus: mhi: Remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efd83fb2-cc8f-f2d8-f967-297f8d695a14@quicinc.com>
Date: Mon, 27 Jan 2025 16:50:10 -0700
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: <linux@...blig.org>, <manivannan.sadhasivam@...aro.org>,
        <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: mhi: Remove unused functions

On 1/27/2025 2:58 PM, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> mhi_device_get() and mhi_queue_dma() haven't been used since 2020's
> commit 189ff97cca53 ("bus: mhi: core: Add support for data transfer")
> added them.
> 
> Remove them.

I suppose it is time to remove them.

> Note that mhi_queue_dma_sync() is used and has been left.

Does it make sense to drop the "sync" postfix since the remaining 
function does not need to distinguish from another implementation?

-Jeff