linux-kernel - mantis_ca_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Z5bXm43f8BLLeCXy@gallifrey>
Date: Mon, 27 Jan 2025 00:47:23 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: mchehab@...nel.org, linux-media@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: mantis_ca_init - missing call???

Hi,
  My scripts noticed that the mantis_ca_init() and mantis_ca_exit()
functions aren't called anywhere; I was about to deadcode them, but
hmm, to me this looks more likely a bug, but I don't know
the code, so thought it best to ask.

mantis_ca_init() sets up a function pointer structure to a whole
bunch of static functions that can't be called; so that means the
whole of mantis_ca.c is dead.

commit b3b961448f70 ("V4L/DVB (13795): [Mantis/Hopper] Code overhaul, add Hopper
devices into the PCI ID list")
removed the only call to mantis_ca_init() in 2009.

Similarly, the last call to mantis_ca_exit() was removed at nearly the same time
by commit 0bdc799b8b82 ("V4L/DVB (13802): [Mantis/Hopper] Fix all build related warnings")

There is a commented out call to mantis_ca_exit() in mantis_dvb.c.

Thanks in advance,

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/