linux-kernel - Re: [PATCH] selftests/vDSO: Fix undefined CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d85f9c94-249a-4847-a323-2f547fe60732@csgroup.eu>
Date: Mon, 27 Jan 2025 09:02:56 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Purva Yeshi <purvayeshi550@...il.com>, skhan@...uxfoundation.org
Cc: shuah@...nel.org, Jason@...c4.com, liaoyu15@...wei.com,
 broonie@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/vDSO: Fix undefined CLONE_NEWTIME by including



Le 26/01/2025 à 11:59, Purva Yeshi a écrit :
> [Vous ne recevez pas souvent de courriers de purvayeshi550@...il.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix the build failure caused by the undefined `CLONE_NEWTIME`.
> Include the `linux/sched.h` header file where the function is defined to
> ensure successful compilation of the selftests.

This is supposed to be already fixed by commit 34d5b600172b ("selftests: 
vDSO: Explicitly include sched.h")

Can you explain what is the exact problem still ? And why linux/sched.h ?

Did you properly build kernel headers before building selftests ?


> 
> Signed-off-by: Purva Yeshi <purvayeshi550@...il.com>
> ---
>   tools/testing/selftests/vDSO/vdso_test_getrandom.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index 95057f7567db..b2c9cf15878b 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -29,6 +29,8 @@
>   #include "vdso_config.h"
>   #include "vdso_call.h"
> 
> +#include <linux/sched.h>
> +
>   #ifndef timespecsub
>   #define        timespecsub(tsp, usp, vsp)                                      \
>          do {                                                            \
> --
> 2.34.1
>