linux-kernel - RE: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver for the Renesas RZ/G3S SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113465C742C78714F7BC09D5786EC2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Mon, 27 Jan 2025 09:11:54 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, Claudiu.Beznea
	<claudiu.beznea@...on.dev>
CC: Jonathan Cameron <jic23@...nel.org>, "rafael@...nel.org"
	<rafael@...nel.org>, "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
	"rui.zhang@...el.com" <rui.zhang@...el.com>, "lukasz.luba@....com"
	<lukasz.luba@....com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "magnus.damm@...il.com" <magnus.damm@...il.com>,
	"mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org"
	<sboyd@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "open list:IIO SUBSYSTEM AND DRIVERS"
	<linux-iio@...r.kernel.org>
Subject: RE: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver for the
 Renesas RZ/G3S SoC

Hi Claudiu,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 27 January 2025 08:55
> Subject: Re: [PATCH 4/6] thermal: renesas: rzg3s: Add thermal driver for the Renesas RZ/G3S SoC
> 
> Hi Claudiu,
> 
> On Mon, 27 Jan 2025 at 09:33, Claudiu Beznea <claudiu.beznea@...on.dev> wrote:
> > On 25.01.2025 14:18, Jonathan Cameron wrote:
> > > On Wed, 22 Jan 2025 11:29:19 +0100
> > > Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > >> On Fri, Jan 3, 2025 at 5:38 PM Claudiu <claudiu.beznea@...on.dev> wrote:
> > >>> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> > >>>
> > >>> The Renesas RZ/G3S SoC features a Thermal Sensor Unit (TSU) that
> > >>> reports the junction temperature. The temperature is reported
> > >>> through a dedicated ADC channel. Add a driver for the Renesas RZ/G3S TSU.
> > >>>
> > >>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> > >>
> > >> Thanks for your patch!
> > >>
> > >>> --- /dev/null
> > >>> +++ b/drivers/thermal/renesas/rzg3s_thermal.c
> > >>
> > >>> +static int rzg3s_thermal_probe(struct platform_device *pdev) {
> > >>> +       struct rzg3s_thermal_priv *priv;
> > >>> +       struct device *dev = &pdev->dev;
> > >>> +       int ret;
> > >>> +
> > >>> +       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > >>> +       if (!priv)
> > >>> +               return -ENOMEM;
> > >>> +
> > >>> +       priv->base = devm_platform_ioremap_resource(pdev, 0);
> > >>> +       if (IS_ERR(priv->base))
> > >>> +               return PTR_ERR(priv->base);
> > >>> +
> > >>> +       priv->channel = devm_iio_channel_get(dev, "tsu");
> > >>
> > >> Given there's only a single IIO channel, you could pass NULL
> > >> instead of the name, and drop "io-channel-names" from the DT bindings.
> > >> I don't know what's the IIO policy w.r.t. unnamed channels, though.
> > >
> > > It's supported, so fine as long as no future additional names show up.
> > > Will just fallback to index 0 I think.
> >
> > If everyone agrees, I would keep the name, too, to avoid complications
> > in case this IP variant will be extended on future SoCs.

If you are planning to extend this driver to other SoCs then may be update
KConfig with dependency on ARCH_RENESAS? see [1]

[1] https://lore.kernel.org/linux-renesas-soc/20250118-trout-of-luxurious-inquire-aae9aa@krzk-bin/

Cheers,
Biju