linux-kernel - Re: [PATCH] serial: pic32: Fix build warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025012735-lustrous-finalize-d47f@gregkh>
Date: Mon, 27 Jan 2025 11:21:56 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Yu-Chun Lin <eleanor15x@...il.com>
Cc: jirislaby@...nel.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, jserv@...s.ncku.edu.tw,
	visitorckw@...il.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] serial: pic32: Fix build warning when CONFIG_OF is
 disabled

On Mon, Jan 27, 2025 at 06:07:13PM +0800, Yu-Chun Lin wrote:
> On Mon, Jan 27, 2025 at 10:12:47AM +0100, Greg KH wrote:
> > > So I should remove of_match_ptr and add the CONFIG_OF as a dependency
> > > for the configuration. Correct?
> > 
> > I don't know, but putting #ifdef in .c files is not the correct solution
> > at all.
> 
> I fixed the build warning this way because I saw it was done the same way
> in these three files:
> 
> drivers/tty/serial/samsung_tty.c 
> drivers/tty/serial/mps2-uart.c
> drivers/tty/serial/altera_jtaguart.c

Those too should be fixed properly.

> Or maybe we can add __maybe_unused to avoid the warning?

No, again, no other bus has this issue, please fix the macros properly.

thanks,

greg k-h