linux-kernel - Re: [PATCH] serial: 8250_pci: Fix Warning at drivers/pci/devres.c:603 pcim_add_mapping_to_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac39e075-ad59-41ba-b47f-59085269ccfa@gmx.de>
Date: Mon, 27 Jan 2025 14:14:13 +0100
From: Helge Deller <deller@....de>
To: Helge Deller <deller@...nel.org>, linux-kernel@...r.kernel.org,
 linux-parisc@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: Fix Warning at drivers/pci/devres.c:603
 pcim_add_mapping_to_legacy_table

On 1/26/25 08:37, Helge Deller wrote:
> Some PA-RISC servers have BMC management cards (Diva) with up to 5 serial
> UARTS per memory PCI bar. This triggers since at least kernel 6.12 for each of
> the UARTS (beside the first one) the following warning in devres.c:
...
>
> I see three options to avoid this warning:
> a) drop the WARNING() from devrec.c,
> b) modify pcim_iomap() to return an existing mapping if it exists
>     instead of creating a new mapping, or
> c) change serial8250_pci_setup_port() to only create a new mapping
>     if none exists yet.
>
> This patch implements option c).

Please ignore this patch as it behaves wrong.
I'll send an updated patch.

Helge