lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1add841d-84d8-48b7-af79-f81c7bd893bd@quicinc.com>
Date: Mon, 27 Jan 2025 18:56:34 +0530
From: Rakesh Kota <quic_kotarake@...cinc.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: <andersson@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <krzk+dt@...nel.org>,
        <quic_jprakash@...cinc.com>, <quic_kamalw@...cinc.com>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <konradybcio@...nel.org>
Subject: Re: [PATCH] arm64: dts: qcs6490-rb3gen2: Add vadc and adc-tm channels


On 1/24/2025 8:56 PM, Rob Herring (Arm) wrote:
> On Fri, 24 Jan 2025 12:32:00 +0530, Rakesh Kota wrote:
>> Add support for vadc and adc-tm channels which are used for
>> monitoring thermistors present on the platform.
>>
>> - Add the necessary includes for qcom,spmi-adc7-pm7325 and
>>    qcom,spmi-adc7-pmk8350.
>> - Add thermal zones for quiet-thermal, sdm-skin-thermal, and
>>    xo-thermal, and define their polling delays and thermal sensors.
>> - Configure the pm7325_temp_alarm node to use the pmk8350_vadc
>>    channel for thermal monitoring.
>> - Configure the pmk8350_adc_tm node to enable its thermal sensors
>>    and define their registers and settings.
>> - Configure the pmk8350_vadc node to define its channels and settings
>>
>> Signed-off-by: Rakesh Kota <quic_kotarake@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 114 +++++++++++++++++++
>>   1 file changed, 114 insertions(+)
>>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>    pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250124070200.3969230-1-quic_kotarake@...cinc.com:
>
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2: pwm:nvmem: [[346, 347]] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm: nvmem: [[346, 347]] is too short
> 	from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@0: adc@...0: 'oneOf' conditional failed, one must be fixed:
> 	'#address-cells', '#size-cells', 'channel@...', 'channel@...', 'channel@...', 'channel@44', 'pmk8350-die-temp@3' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	'#address-cells', '#size-cells', 'channel@...', 'channel@...', 'channel@...', 'channel@44', 'interrupts', 'pmk8350-die-temp@3' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	'pmk8350-die-temp@3' does not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 	['qcom,spmi-adc7'] is too short
> 	'qcom,spmi-adc7' is not one of ['qcom,pm8226-iadc', 'qcom,pm8941-iadc']
> 	'qcom,spmi-adc7' is not one of ['qcom,pmi8998-rradc', 'qcom,pm660-rradc']
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: adc@...0: 'pmk8350-die-temp@3' does not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/iio/adc/qcom,spmi-vadc.yaml#

Thank you for your review..!
And After updating the dt-schema, I am also encountering the same error
According to the documentation, I need to change the pmk8350-die-temp 
channel name to channel@3. I will correct this in the next patch set.

>
>
>
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ