linux-kernel - Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250127160236.GJ16742@noisy.programming.kicks-ass.net>
Date: Mon, 27 Jan 2025 17:02:36 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: kevin.brodsky@....com, riel@...riel.com, vishal.moola@...il.com,
	david@...hat.com, jannh@...gle.com, hughd@...gle.com,
	willy@...radead.org, yuzhao@...gle.com, muchun.song@...ux.dev,
	akpm@...ux-foundation.org, will@...nel.org, aneesh.kumar@...nel.org,
	npiggin@...il.com, arnd@...db.de, dave.hansen@...ux.intel.com,
	rppt@...nel.org, alexghiti@...osinc.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-csky@...r.kernel.org,
	linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
	linux-openrisc@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-um@...ts.infradead.org, x86@...nel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table()

On Fri, Jan 24, 2025 at 09:00:58PM +0800, Qi Zheng wrote:
> 
> 
> On 2025/1/24 19:38, Peter Zijlstra wrote:
> > On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote:
> > > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table()
> > > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use
> > > tlb_remove_table() unconditionally to free page table pages.
> > > 
> > > Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> > > Suggested-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > 
> > I think we can clean up more :-)
> 
> Yes, but Rik van Riel has already done the same thing in his patch series
> [1], so I was originally planning to wait for his patch to be
> merged into the linux-next branch, and then rebase this series onto his
> patch.

Duh, yeah, I've actually seen those patches and totally forgot he did
that... -ETOOMUCHEMAIL :/