linux-kernel - [PATCH] ALSA: pcm: use new array-copying-wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250127160655.3119470-1-cy1yang@outlook.com>
Date: Mon, 27 Jan 2025 10:06:55 -0600
From: yangchenyuan <chenyuan0y@...il.com>
To: perex@...ex.cz,
	tiwai@...e.com,
	viro@...iv.linux.org.uk,
	brauner@...nel.org,
	pavel.hofman@...tera.com,
	jbrunet@...libre.com
Cc: linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	zijie98@...il.com,
	Chenyuan Yang <chenyuan0y@...il.com>
Subject: [PATCH] ALSA: pcm: use new array-copying-wrapper

From: Chenyuan Yang <chenyuan0y@...il.com>

This is found by our static analysis tool.

pcm_native.c utilizes memdup_user() to copy an array from userspace.

There is a new wrapper, specifically designed for copying arrays. Use
this one instead.

This is similar to the 
commit 3e91a38de1dc ("fbdev: viafb: use new array-copying-wrapper").

Fixes: 67616feda99e ("ALSA: pcm: Unify ioctl functions for playback and capture streams")
Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
---
 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 8a3384342e8d..6c2b6a62d9d2 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3245,7 +3245,7 @@ static int snd_pcm_xfern_frames_ioctl(struct snd_pcm_substream *substream,
 	if (copy_from_user(&xfern, _xfern, sizeof(xfern)))
 		return -EFAULT;
 
-	bufs = memdup_user(xfern.bufs, sizeof(void *) * runtime->channels);
+	bufs = memdup_array_user(xfern.bufs, runtime->channels, sizeof(void *));
 	if (IS_ERR(bufs))
 		return PTR_ERR(bufs);
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-- 
2.34.1