linux-kernel - Re: [PATCH v2] perf annotate: Use an array for the disassembler preference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173800288595.34239.10214825871343123909.b4-ty@kernel.org>
Date: Mon, 27 Jan 2025 10:34:45 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Mark Rutland <mark.rutland@....com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
 Kan Liang <kan.liang@...ux.intel.com>, 
 Justin Stitt <justinstitt@...gle.com>, 
 Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, 
 Andi Kleen <ak@...ux.intel.com>, Kajol Jain <kjain@...ux.ibm.com>, 
 Li Huafei <lihuafei1@...wei.com>, linux-perf-users@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v2] perf annotate: Use an array for the disassembler
 preference

On Thu, 23 Jan 2025 20:38:56 -0800, Ian Rogers wrote:

> Prior to this change a string was used which could cause issues with
> an unrecognized disassembler in symbol__disassembler. Change to
> initializing an array of perf_disassembler enum values. If a value
> already exists then adding it a second time is ignored to avoid array
> out of bounds problems present in the previous code, it also allows a
> statically sized array and removes memory allocation needs. Errors in
> the disassembler string are reported when the config is parsed during
> perf annotate or perf top start up. If the array is uninitialized
> after processing the config file the default llvm, capstone then
> objdump values are added but without a need to parse a string.
> 
> [...]

Applied to perf-tools, thanks!

Best regards,
Namhyung