linux-kernel - Re: [PATCH v2] sched_ext: Move built-in idle CPU selection policy to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5fcL-e5Jf3yt53Y@slm.duckdns.org>
Date: Mon, 27 Jan 2025 09:19:11 -1000
From: Tejun Heo <tj@...nel.org>
To: Andrea Righi <arighi@...dia.com>
Cc: David Vernet <void@...ifault.com>, Changwoo Min <changwoo@...lia.com>,
	Yury Norov <yury.norov@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sched_ext: Move built-in idle CPU selection policy to
 a separate file

On Sat, Jan 25, 2025 at 10:39:11PM +0100, Andrea Righi wrote:
...
> @@ -7823,6 +7110,12 @@ static int __init scx_init(void)
>  					     &scx_kfunc_set_unlocked)) ||
>  	    (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
>  					     &scx_kfunc_set_unlocked)) ||
> +	    (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS,
> +					     &scx_kfunc_set_idle)) ||
> +	    (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> +					     &scx_kfunc_set_idle)) ||
> +	    (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
> +					     &scx_kfunc_set_idle)) ||

Just one more change. Can you please make the set themselves static in
ext_idle.c and then register them from its own init function which is called
from scx_init()?

Thanks.

-- 
tejun