lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202501280314.duK3nD3Q-lkp@intel.com>
Date: Tue, 28 Jan 2025 03:42:26 +0800
From: kernel test robot <lkp@...el.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	"Gustavo A. R. Silva" <gustavo@...eddedor.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [gustavoars:testing/wfamnae-next20250124 6/15]
 drivers/net/wireless/intel/iwlwifi/mvm/d3.c:2163:2: error: call to
 '__compiletime_assert_1138' declared with 'error' attribute: BUILD_BUG_ON
 failed: conf->keylen < WLAN_KEY_LEN_GCMP_256

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/wfamnae-next20250124
head:   86b653e4edef7b0f7b7afe5dd8e0241fc1165238
commit: e37f7001ef33528ce10e3821fc5c07b84fc4fca7 [6/15] wifi: iwlwifi: mvm: Use __counted_by() and avoid -Wfamnae warnings
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20250128/202501280314.duK3nD3Q-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 19306351a2c45e266fa11b41eb1362b20b6ca56d)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250128/202501280314.duK3nD3Q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501280314.duK3nD3Q-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/wireless/intel/iwlwifi/mvm/d3.c:7:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:17:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:8:
   In file included from include/linux/cacheflush.h:5:
   In file included from arch/riscv/include/asm/cacheflush.h:9:
   In file included from include/linux/mm.h:2224:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/mvm/d3.c:2163:2: error: call to '__compiletime_assert_1138' declared with 'error' attribute: BUILD_BUG_ON failed: conf->keylen < WLAN_KEY_LEN_GCMP_256
    2163 |         BUILD_BUG_ON(conf->keylen < WLAN_KEY_LEN_GCMP_256);
         |         ^
   include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^
   include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^
   include/linux/compiler_types.h:542:2: note: expanded from macro 'compiletime_assert'
     542 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^
   include/linux/compiler_types.h:530:2: note: expanded from macro '_compiletime_assert'
     530 |         __compiletime_assert(condition, msg, prefix, suffix)
         |         ^
   include/linux/compiler_types.h:523:4: note: expanded from macro '__compiletime_assert'
     523 |                         prefix ## suffix();                             \
         |                         ^
   <scratch space>:167:1: note: expanded from here
     167 | __compiletime_assert_1138
         | ^
>> drivers/net/wireless/intel/iwlwifi/mvm/d3.c:2162:2: error: call to '__compiletime_assert_1137' declared with 'error' attribute: BUILD_BUG_ON failed: conf->keylen < WLAN_KEY_LEN_CCMP
    2162 |         BUILD_BUG_ON(conf->keylen < WLAN_KEY_LEN_CCMP);
         |         ^
   include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^
   include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^
   include/linux/compiler_types.h:542:2: note: expanded from macro 'compiletime_assert'
     542 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^
   include/linux/compiler_types.h:530:2: note: expanded from macro '_compiletime_assert'
     530 |         __compiletime_assert(condition, msg, prefix, suffix)
         |         ^
   include/linux/compiler_types.h:523:4: note: expanded from macro '__compiletime_assert'
     523 |                         prefix ## suffix();                             \
         |                         ^
   <scratch space>:163:1: note: expanded from here
     163 | __compiletime_assert_1137
         | ^
   3 warnings and 2 errors generated.


vim +2163 drivers/net/wireless/intel/iwlwifi/mvm/d3.c

  2148	
  2149	static bool iwl_mvm_gtk_rekey(struct iwl_wowlan_status_data *status,
  2150				      struct ieee80211_vif *vif,
  2151				      struct iwl_mvm *mvm, u32 gtk_cipher)
  2152	{
  2153		int i, j;
  2154		struct ieee80211_key_conf *key;
  2155		DEFINE_FLEX(struct ieee80211_key_conf, conf, key, keylen,
  2156			    WOWLAN_KEY_MAX_SIZE);
  2157		int link_id = vif->active_links ? __ffs(vif->active_links) : -1;
  2158	
  2159		conf->cipher = gtk_cipher;
  2160	
  2161		BUILD_BUG_ON(WLAN_KEY_LEN_CCMP != WLAN_KEY_LEN_GCMP);
> 2162		BUILD_BUG_ON(conf->keylen < WLAN_KEY_LEN_CCMP);
> 2163		BUILD_BUG_ON(conf->keylen < WLAN_KEY_LEN_GCMP_256);
  2164		BUILD_BUG_ON(conf->keylen < WLAN_KEY_LEN_TKIP);
  2165		BUILD_BUG_ON(conf->keylen < sizeof(status->gtk[0].key));
  2166	
  2167		switch (gtk_cipher) {
  2168		case WLAN_CIPHER_SUITE_CCMP:
  2169		case WLAN_CIPHER_SUITE_GCMP:
  2170			conf->keylen = WLAN_KEY_LEN_CCMP;
  2171			break;
  2172		case WLAN_CIPHER_SUITE_GCMP_256:
  2173			conf->keylen = WLAN_KEY_LEN_GCMP_256;
  2174			break;
  2175		case WLAN_CIPHER_SUITE_TKIP:
  2176			conf->keylen = WLAN_KEY_LEN_TKIP;
  2177			break;
  2178		default:
  2179			WARN_ON(1);
  2180		}
  2181	
  2182		for (i = 0; i < ARRAY_SIZE(status->gtk); i++) {
  2183			if (!status->gtk[i].len)
  2184				continue;
  2185	
  2186			conf->keyidx = status->gtk[i].id;
  2187			IWL_DEBUG_WOWLAN(mvm,
  2188					 "Received from FW GTK cipher %d, key index %d\n",
  2189					 conf->cipher, conf->keyidx);
  2190			memcpy(conf->key, status->gtk[i].key,
  2191			       sizeof(status->gtk[i].key));
  2192	
  2193			key = ieee80211_gtk_rekey_add(vif, conf, link_id);
  2194			if (IS_ERR(key))
  2195				return false;
  2196	
  2197			for (j = 0; j < ARRAY_SIZE(status->gtk_seq); j++) {
  2198				if (!status->gtk_seq[j].valid ||
  2199				    status->gtk_seq[j].key_id != key->keyidx)
  2200					continue;
  2201				iwl_mvm_set_key_rx_seq_idx(key, status, j);
  2202				break;
  2203			}
  2204			WARN_ON(j == ARRAY_SIZE(status->gtk_seq));
  2205		}
  2206	
  2207		return true;
  2208	}
  2209	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ