linux-kernel - Re: [PATCH] tests/module: nix-ify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5lAD6uyFnyBBJp6@bombadil.infradead.org>
Date: Tue, 28 Jan 2025 12:37:35 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Joel Granados <joel.granados@...nel.org>,
	Petr Pavlu <petr.pavlu@...e.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tests/module: nix-ify

On Wed, Jan 22, 2025 at 11:33:49AM +0100, Joel Granados wrote:
> Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary
> for nix environments as they only provide /usr/bin/env at the standard
> location.
> 
> Signed-off-by: Joel Granados <joel.granados@...nel.org>

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

This can go through the modules tree.

  Luis

> ---
> I just saw this break my allyes test build. I had usually done it in
> debian, but now that its on NixOs; this patch corrects the build error.
> ---
>  lib/tests/module/gen_test_kallsyms.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/tests/module/gen_test_kallsyms.sh b/lib/tests/module/gen_test_kallsyms.sh
> index 561dcac0f359..31fe4ed63de8 100755
> --- a/lib/tests/module/gen_test_kallsyms.sh
> +++ b/lib/tests/module/gen_test_kallsyms.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  TARGET=$(basename $1)
>  DIR=lib/tests/module
> 
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250122-jag-nix-ify-1aa2061c4ad8
> 
> Best regards,
> -- 
> Joel Granados <joel.granados@...nel.org>
> 
>