linux-kernel - Re: [PATCH 1/4] rcutorture: Allow a negative value for nfakewriters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec8a3ccb-b3d7-421d-86c6-e1035b69cd55@paulmck-laptop>
Date: Tue, 28 Jan 2025 13:19:29 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Uladzislau Rezki <urezki@...il.com>
Cc: Boqun Feng <boqun.feng@...il.com>, RCU <rcu@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <frederic@...nel.org>,
	Cheung Wall <zzqq0103.hey@...il.com>,
	Neeraj upadhyay <Neeraj.Upadhyay@....com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH 1/4] rcutorture: Allow a negative value for nfakewriters

On Tue, Jan 28, 2025 at 09:55:19PM +0100, Uladzislau Rezki wrote:
> Hello, Paul!
> 
> > Currently "nfakewriters" parameter can be set to any value but
> > there is no possibility to adjust it automatically based on how
> > many CPUs a system has where a test is run on.
> > 
> > To address this, if the "nfakewriters" is set to negative it will
> > be adjusted to num_possible_cpus() during torture initialization.
> > 
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> > ---
> >  kernel/rcu/rcutorture.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> > index d26fb1d33ed9..6bc161e1e8ac 100644
> > --- a/kernel/rcu/rcutorture.c
> > +++ b/kernel/rcu/rcutorture.c
> > @@ -4050,6 +4050,10 @@ rcu_torture_init(void)
> >  					  writer_task);
> >  	if (torture_init_error(firsterr))
> >  		goto unwind;
> > +
> > +	if (nfakewriters < 0)
> > +		nfakewriters = (int) num_possible_cpus();
> > +
> >  	if (nfakewriters > 0) {
> >  		fakewriter_tasks = kcalloc(nfakewriters,
> >  					   sizeof(fakewriter_tasks[0]),
> > -- 
> > 2.39.5
> > 
> 
> Don't you mind to take this as well? It is needed for:
> 
> rcu: Update TREE05.boot to test normal synchronize_rcu()

I would, but could you please set something up like we have for
nreaders (the module parameter) and nrealreaders (the value actually
used throughout).  I freely admit that nrealfakereaders sounds a bit
strange, so please feel free to either embrace the strangeness or propose
an alternative.  ;-)

The reason for this is so that, on a system with 128 CPUs, the user can
distinguish between having specified (say) nfakewriters=128 on the one
hand or nfakewriters=-1 on the other.

							Thanx, Paul