linux-kernel - Re: [PATCH RFC WIP v2] rust: add bitfield_options macro to create bitfield wrapper types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pm2SERyezYBsg6ObyoVI8L-aNe4GrIxxp7gEfrBPnOhtx3JNnaQrUXsNTq8sh9lumoPjlI2qwZ2edpEgyV3JxbBqIU9JWHPmaUJT_MosuFs=@protonmail.com>
Date: Tue, 28 Jan 2025 21:24:03 +0000
From: Timothy Garwood <gtimothy-dev@...tonmail.com>
To: Daniel Sedlak <daniel@...lak.dev>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH RFC WIP v2] rust: add bitfield_options macro to create bitfield wrapper types


> What I think is actually missing is an another patch integrating this or
> showing usage of this somewhere, for example in samples/drivers.

I did just that here: [1]
Link: https://lore.kernel.org/rust-for-linux/20250128-add-bitfield-options-macro-v2-1-d65349b389fc@protonmail.com [1]

Maybe I should have made a second patch in this series instead of a new 
series but since this usage example depends on the HrTimer patch series I
thought it best to separate. I am new here though, so I may very well be 
wrong about that.
[1] depended on this v2 so I could not reference it in the v2, I think. I
will reference it in the v3.


> Missing period at the end.
Will fix, thanks.

> Capitalization of the first word.

Will fix thanks.

> This might be opinionated, but it may be better to use positional
> parameters [1] as it is not that noisy to read in the source code.

I have no opinion on this, I'll make the change for readability.

> > +///```rust
> The rust is implicit.

I'll remove them all then.

Thank you Daniel,
Timothy