linux-kernel - Re: [PATCH] ACPI: GTDT: Relax sanity checking on Platform Timers array count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzaftjev.wl-maz@kernel.org>
Date: Tue, 28 Jan 2025 08:46:48 +0000
From: Marc Zyngier <maz@...nel.org>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: linux-acpi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Hanjun Guo <guohanjun@...wei.com>,
	Sudeep Holla <sudeep.holla@....com>,
	Will Deacon <will@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Zheng Zengkai <zhengzengkai@...wei.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] ACPI: GTDT: Relax sanity checking on Platform Timers array count

On Tue, 28 Jan 2025 00:17:49 +0000,
Oliver Upton <oliver.upton@...ux.dev> wrote:
> 
> Perhaps unsurprisingly there are some platforms where the GTDT isn't
> quite right and the Platforms Timer array overflows the length of the
> overall table.

Colour me shocked! Broken ACPI tables? [insert REM song here].

> 
> While the recently-added sanity checking isn't wrong, it makes it
> impossible to boot the kernel on offending platforms. Try to hobble
> along and limit the Platform Timer count to the bounds of the table.
> 
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Zheng Zengkai <zhengzengkai@...wei.com>
> Cc: stable@...r.kernel.org
> Fixes: 263e22d6bd1f ("ACPI: GTDT: Tighten the check for the array of platform timer structures")
> Signed-off-by: Oliver Upton <oliver.upton@...ux.dev>

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.