linux-kernel - Re: init: Unnecessary braces around single line statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5iiX9clA62t8Llf@pathway.suse.cz>
Date: Tue, 28 Jan 2025 10:24:47 +0100
From: Petr Mladek <pmladek@...e.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Markus Elfring <Markus.Elfring@....de>,
	Jeremy Dean Clifton <deaner92@...oo.com>,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Huang Shijie <shijie@...amperecomputing.com>,
	Ingo Molnar <mingo@...nel.org>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Paul Menzel <pmenzel@...gen.mpg.de>,
	Raul Rangel <rrangel@...omium.org>, Tejun Heo <tj@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yuntao Wang <ytcoode@...il.com>
Subject: Re: init: Unnecessary braces around single line statement

On Tue 2025-01-28 09:59:08, Christophe Leroy wrote:
> 
> 
> Le 28/01/2025 à 09:45, Markus Elfring a écrit :
> > > So ask yourself whether such a change is really worth it.
> > Some change combinations can occasionally become more worthwhile,
> > can't they?
> 
> Sure that change would be perfect as part of a series which modifies
> bootconfig_params(), but as a standalone change I can't see the benefit.

I agree here:

1. Cosmetic changes just complicate merging branches with really
   useful changes. They are complicate backporting fixes to
   stable kernels.

2. Cosmetic changes are material for bikeshedding. Some people might
   prefer the original code because it is better readable for them...

3. The authors of cosmetic changes will not learn much by this.
   Also it will also not help much to gain any reputation.

Best Regards,
Petr