linux-kernel - Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using ACPI PRMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5ijZaxrEuKDlpXa@rric.localdomain>
Date: Tue, 28 Jan 2025 10:29:09 +0100
From: Robert Richter <rrichter@....com>
To: Ben Cheatham <benjamin.cheatham@....com>
Cc: linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using
 ACPI PRMT

On 17.01.25 15:32:25, Ben Cheatham wrote:
> On 1/7/25 8:10 AM, Robert Richter wrote:

> > +static u64 cxl_zen5_to_hpa(struct cxl_decoder *cxld, u64 hpa)
> 
> After reading through your discussion with Gregory I'm not confused about the function name
> anymore, but I would definitely include a comment specifying the expected usage and return value.

I am going to add that description to struct cxl_port where the
callback is implemented.

Thanks for review,

-Robert