lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <173806684396.1748.12048181273043599788.b4-ty@linux.intel.com>
Date: Tue, 28 Jan 2025 14:20:43 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Ike Panhc <ike.pan@...onical.com>, Hans de Goede <hdegoede@...hat.com>, 
 Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Kurt Borja <kuurtb@...il.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>, 
 Mario Limonciello <mario.limonciello@....com>, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: pass a correct pointer
 to the driver data

On Tue, 28 Jan 2025 00:02:01 +0300, Fedor Pchelkin wrote:

> devm_platform_profile_register() expects a pointer to the private driver
> data but instead an address of the pointer variable is passed due to a
> typo. This leads to the crashes later:
> 
> BUG: unable to handle page fault for address: 00000000fe0d0044
> PGD 0 P4D 0
> Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
> CPU: 6 UID: 0 PID: 1284 Comm: tuned Tainted: G        W          6.13.0+ #7
> Tainted: [W]=WARN
> Hardware name: LENOVO 21D0/LNVNB161216, BIOS J6CN45WW 03/17/2023
> RIP: 0010:__mutex_lock.constprop.0+0x6bf/0x7f0
> Call Trace:
>  <TASK>
>  dytc_profile_set+0x4a/0x140 [ideapad_laptop]
>  _store_and_notify+0x13/0x40 [platform_profile]
>  class_for_each_device+0x145/0x180
>  platform_profile_store+0xc0/0x130 [platform_profile]
>  kernfs_fop_write_iter+0x13e/0x1f0
>  vfs_write+0x290/0x450
>  ksys_write+0x6c/0xe0
>  do_syscall_64+0x82/0x160
>  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: ideapad-laptop: pass a correct pointer to the driver data
      commit: 9a9b61337751ed9e6827b467771f6e880b5c733c

--
 i.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ