linux-kernel - Re: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <918d6885-969e-46f1-b414-614905b12831@kernel.org>
Date: Tue, 28 Jan 2025 15:18:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swathi K S <swathi.ks@...sung.com>, robh@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 conor+dt@...nel.org, richardcochran@...il.com, mcoquelin.stm32@...il.com,
 andrew@...n.ch, alim.akhtar@...sung.com, linux-fsd@...la.com
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 alexandre.torgue@...s.st.com, peppe.cavallaro@...com, joabreu@...opsys.com,
 rcsekar@...sung.com, ssiddha@...la.com, jayati.sahu@...sung.com,
 pankaj.dubey@...sung.com, ravi.patel@...sung.com, gost.dev@...sung.com
Subject: Re: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC
 Block of FSD SoC

On 28/01/2025 11:25, Swathi K S wrote:
>  
>  &pinctrl_pmu {
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index cc67930ebf78..670f6a852542 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -1027,6 +1027,33 @@
>  			phy-mode = "rgmii-id";
>  			status = "disabled";
>  		};
> +
> +		ethernet_1: ethernet@...00000 {

Don't add nodes to the end, because that lead to mess we have there.
Squeeze it somewhere where impact on resorting would be the smallest.

Best regards,
Krzysztof