linux-kernel - Re: [PATCH] ALSA: pcm: use new array-copying-wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALGdzurXfO+fwVJ+JR5de-KfsudeBYdYkYRObBtU3mMq5vN5ug@mail.gmail.com>
Date: Tue, 28 Jan 2025 10:06:48 -0600
From: Chenyuan Yang <chenyuan0y@...il.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: perex@...ex.cz, tiwai@...e.com, viro@...iv.linux.org.uk, 
	brauner@...nel.org, pavel.hofman@...tera.com, jbrunet@...libre.com, 
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, zijie98@...il.com
Subject: Re: [PATCH] ALSA: pcm: use new array-copying-wrapper

Hi Takashi,

It looks great to me! Thanks so much for your help!

Best,
Chenyuan

On Tue, Jan 28, 2025 at 1:49 AM Takashi Iwai <tiwai@...e.de> wrote:
>
> On Mon, 27 Jan 2025 17:06:55 +0100,
> yangchenyuan wrote:
> >
> > From: Chenyuan Yang <chenyuan0y@...il.com>
> >
> > This is found by our static analysis tool.
> >
> > pcm_native.c utilizes memdup_user() to copy an array from userspace.
> >
> > There is a new wrapper, specifically designed for copying arrays. Use
> > this one instead.
> >
> > This is similar to the
> > commit 3e91a38de1dc ("fbdev: viafb: use new array-copying-wrapper").
> >
> > Fixes: 67616feda99e ("ALSA: pcm: Unify ioctl functions for playback and capture streams")
>
> This use of Fixes tag is misleading: the original code is correct, per
> se, and the original commit was 4.14, where it had no no
> memdup_array_user() available (introduced since 6.7).
>
> So I applied with the drop of Fixes tag.
>
>
> thanks,
>
> Takashi