[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <j5vgb5kcjs2ax3kws6rlbcca57set22ncj6onvgbm4xwjtw43t@uplzdjywzrkr>
Date: Tue, 28 Jan 2025 17:14:06 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Dave Stevenson <dave.stevenson@...pberrypi.com>,
MaĆra Canal <mcanal@...lia.com>, Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 08/10] drm/display: bridge-connector: handle CEC
adapters
On Sun, Jan 26, 2025 at 03:29:13PM +0200, Dmitry Baryshkov wrote:
> /* -----------------------------------------------------------------------------
> * Bridge Connector Initialisation
> */
> @@ -633,6 +711,21 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
> if (ret)
> return ERR_PTR(ret);
> }
> +
> + if (bridge->hdmi_cec_adapter_name) {
> + if (!bridge->funcs->hdmi_cec_enable ||
> + !bridge->funcs->hdmi_cec_log_addr ||
> + !bridge->funcs->hdmi_cec_transmit)
> + return ERR_PTR(-EINVAL);
> +
> + ret = drm_connector_hdmi_cec_register(connector,
> + &drm_bridge_connector_hdmi_cec_ops,
> + bridge->hdmi_cec_adapter_name,
> + bridge->hdmi_cec_available_las,
> + bridge->hdmi_dev);
> + if (ret)
> + return ERR_PTR(ret);
> + }
Maybe we can use a different bridge feature flag to trigger the CEC code
support instead?
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)
Powered by blists - more mailing lists