linux-kernel - Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250128161737.GD11869@strace.io>
Date: Tue, 28 Jan 2025 18:17:37 +0200
From: "Dmitry V. Levin" <ldv@...ace.io>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Oleg Nesterov <oleg@...hat.com>, linux-snps-arc@...ts.infradead.org,
	Rich Felker <dalias@...c.org>, Thomas Gleixner <tglx@...utronix.de>,
	Andreas Larsson <andreas@...sler.com>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	x86@...nel.org, Arnd Bergmann <arnd@...db.de>,
	linux-mips@...r.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	Guo Ren <guoren@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	sparclinux@...r.kernel.org, linux-hexagon@...r.kernel.org,
	WANG Xuerui <kernel@...0n.name>, Will Deacon <will@...nel.org>,
	Eugene Syromyatnikov <evgsyr@...il.com>,
	Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Jonas Bonn <jonas@...thpole.se>, linux-s390@...r.kernel.org,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-sh@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
	Helge Deller <deller@....de>, Huacai Chen <chenhuacai@...nel.org>,
	Russell King <linux@...linux.org.uk>, linux-csky@...r.kernel.org,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>, Vineet Gupta <vgupta@...nel.org>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	strace-devel@...ts.strace.io, linux-arch@...r.kernel.org,
	Albert Ou <aou@...s.berkeley.edu>,
	Mike Frysinger <vapier@...too.org>,
	Davide Berardi <berardi.dav@...il.com>,
	Renzo Davoli <renzo@...unibo.it>, linux-um@...ts.infradead.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Charlie Jenkins <charlie@...osinc.com>,
	Naveen N Rao <naveen@...nel.org>,
	Nicholas Piggin <npiggin@...il.com>,
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
	Borislav Petkov <bp@...en8.de>, loongarch@...ts.linux.dev,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Stafford Horne <shorne@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Brian Cain <bcain@...cinc.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	linux-parisc@...r.kernel.org, linux-openrisc@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Dinh Nguyen <dinguyen@...nel.org>, linux-riscv@...ts.infradead.org,
	Palmer Dabbelt <palmer@...belt.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Richard Weinberger <richard@....at>,
	Johannes Berg <johannes@...solutions.net>,
	Alexey Gladkov <legion@...nel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and
 syscall_set_return_value()

On Tue, Jan 28, 2025 at 04:04:34PM +0100, Christophe Leroy wrote:
> Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit :
> > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK
> > architectures to implement PTRACE_SET_SYSCALL_INFO API.
> 
> The subject is misleading. syscall_set_return_value() already exists on 
> most architectures and was not addressed by commit 7962c2eddbfe.
> 
> Maybe it would be better to handle syscall_set_return_value() in a 
> separate commit.

syscall_set_return_value() is being added only on hexagon.
I didn't think it worth a separate commit, but it's certainly possible
to split this commit into two.


-- 
ldv