linux-kernel - [PATCH] selftests: pid_namespace and pidfd missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250128170447.12918-1-alessandro.zanni87@gmail.com>
Date: Tue, 28 Jan 2025 18:04:45 +0100
From: Alessandro Zanni <alessandro.zanni87@...il.com>
To: brauner@...nel.org,
	shuah@...nel.org
Cc: Alessandro Zanni <alessandro.zanni87@...il.com>,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: [PATCH] selftests: pid_namespace and pidfd missing include

Running "make kselftest" results in several errors like these:

pidfd_fdinfo_test.c:231:36: error: ‘MS_REC’ undeclared (first use in
this function)
  231 |         r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);

pidfd_fdinfo_test.c:231:45: error: ‘MS_PRIVATE’ undeclared (first use
in this function); did you mean ‘MAP_PRIVATE’?
  231 |         r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);

pid_max.c:48:9: warning: implicit declaration of function ‘umount2’;
did you mean ‘SYS_umount2’? [-Wimplicit-function-declaration]
   48 |         umount2("/proc", MNT_DETACH);

This patch adds the <sys/mount.h> include in pidfd_fdinfo_test.c and
pid_max.c files to find the variables MS_REC, MS_PRIVATE, MNT_DETACH.

Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
---
 tools/testing/selftests/pid_namespace/pid_max.c   | 1 +
 tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
index 51c414faabb0..972bedc475f1 100644
--- a/tools/testing/selftests/pid_namespace/pid_max.c
+++ b/tools/testing/selftests/pid_namespace/pid_max.c
@@ -11,6 +11,7 @@
 #include <string.h>
 #include <syscall.h>
 #include <sys/wait.h>
+#include <sys/mount.h>
 
 #include "../kselftest_harness.h"
 #include "../pidfd/pidfd.h"
diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
index f062a986e382..f718aac75068 100644
--- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
@@ -13,6 +13,7 @@
 #include <syscall.h>
 #include <sys/wait.h>
 #include <sys/mman.h>
+#include <sys/mount.h>
 
 #include "pidfd.h"
 #include "../kselftest.h"
-- 
2.43.0