linux-kernel - Re: [PATCH] nfsd: validate the nfsd_serv pointer before calling svc_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173808393439.39052.5320146579477812509.b4-ty@oracle.com>
Date: Tue, 28 Jan 2025 12:07:16 -0500
From: cel@...nel.org
To: Neil Brown <neilb@...e.de>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	Jeff Layton <jlayton@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Salvatore Bonaccorso <carnil@...ian.org>,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: validate the nfsd_serv pointer before calling svc_wake_up

From: Chuck Lever <chuck.lever@...cle.com>

On Sat, 25 Jan 2025 20:13:18 -0500, Jeff Layton wrote:
> nfsd_file_dispose_list_delayed can be called from the filecache
> laundrette, which is shut down after the nfsd threads are shut down and
> the nfsd_serv pointer is cleared. If nn->nfsd_serv is NULL then there
> are no threads to wake.
> 
> Ensure that the nn->nfsd_serv pointer is non-NULL before calling
> svc_wake_up in nfsd_file_dispose_list_delayed. This is safe since the
> svc_serv is not freed until after the filecache laundrette is cancelled.
> 
> [...]

Applied to nfsd-testing, thanks!

Test experience should demonstrate whether more strict memory
ordering semantics are needed.

[1/1] nfsd: validate the nfsd_serv pointer before calling svc_wake_up
      commit: 363683ced1718d66ad54e1bdf52d41d544f783b2

--
Chuck Lever