linux-kernel - Re: [PATCH] Fix DWC3 documentation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250128011411.b22j6vmqqzuvrcsi@synopsys.com>
Date: Tue, 28 Jan 2025 01:14:26 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Camila Alvarez <cam.alvarez.i@...il.com>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix DWC3 documentation warning

On Sat, Jan 18, 2025, Camila Alvarez wrote:
> Fixes ./drivers/usb/dwc3/core.h:983: warning: Function parameter or struct member 'sg' not described in 'dwc3_request'
> 
> Signed-off-by: Camila Alvarez <cam.alvarez.i@...il.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index f11570c8ffd0..ec74d5859343 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>   * @request: struct usb_request to be transferred
>   * @list: a list_head used for request queueing
>   * @dep: struct dwc3_ep owning this request
> + * @sg: pointer to first incomplete sg 
>   * @start_sg: pointer to the sg which should be queued next
>   * @num_pending_sgs: counter to pending sgs
>   * @remaining: amount of data remaining
> -- 
> 2.34.1
> 

This is not a correct fix.

See below fix that was already applied:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=686d4a2c26b49eaf6e817f16b7cb6c4b961aa7a7

BR,
Thinh