linux-kernel - Re: [PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or set sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf0e9c67-b1c9-4e39-8af0-ff2bdc493359@linux.dev>
Date: Wed, 29 Jan 2025 13:20:27 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: zhangmingyi <zhangmingyi5@...wei.com>
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, song@...nel.org,
 yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
 haoluo@...gle.com, jolsa@...nel.org, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org, yanan@...wei.com, wuchangye@...wei.com,
 xiesongyang@...wei.com, liuxin350@...wei.com, liwei883@...wei.com,
 tianmuyang@...wei.com
Subject: Re: [PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or
 set sockets

On 1/27/25 1:07 AM, zhangmingyi wrote:
> Note that tcp_getsockopt and tcp_setsockopt support TCP_ULP, while
> bpf_getsockopt and bpf_setsockopt do not support TCP_ULP.
> I'm not sure why there is such a difference, but I noticed that
> tcp_setsockopt is called in bpf_setsockopt.I think we can add the
> handling of this case.
> 
> Signed-off-by: zhangmingyi <zhangmingyi5@...wei.com>

A nit that I found it useful to recognize different authors of the mailing list. 
It would be easier to have a formatted name. It seems "Mingyi Zhang" was used 
earlier, as seen by searching the git log history.