linux-kernel - Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5qeoqRZKjiR1YAD@pollux>
Date: Wed, 29 Jan 2025 22:33:22 +0100
From: Danilo Krummrich <dakr@...nel.org>
To: Christoph Hellwig <hch@....de>, Greg KH <gregkh@...uxfoundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Abdiel Janulgue <abdiel.janulgue@...il.com>,
	daniel.almeida@...labora.com, aliceryhl@...gle.com,
	robin.murphy@....com, rust-for-linux@...r.kernel.org,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Valentin Obst <kernel@...entinobst.de>,
	open list <linux-kernel@...r.kernel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>, airlied@...hat.com,
	"open list:DMA MAPPING HELPERS" <iommu@...ts.linux.dev>
Subject: Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.

On Tue, Jan 28, 2025 at 10:23:34AM +0100, Christoph Hellwig wrote:
> On Thu, Jan 16, 2025 at 02:17:24PM +0100, Danilo Krummrich wrote:
> > Since there hasn't been a reply so far, I assume that we're good with
> > maintaining the DMA Rust abstractions separately.
> 
> No, I'm not.  This was an explicit:
> 
> Nacked-by: Christoph Hellwig <hch@....de>
> 
> And I also do not want another maintainer.  If you want to make Linux
> impossible to maintain due to a cross-language codebase do that in
> your driver so that you have to do it instead of spreading this cancer
> to core subsystems.  (where this cancer explicitly is a cross-language
> codebase and not rust itself, just to escape the flameware brigade).

I accept that you don't want to be involved with Rust in the kernel, which is
why we offered to maintain the Rust abstraction layer for the DMA coherent
allocator as a separate component (which it would be anyways) ourselves.

As explained previously, this component is just a user of the DMA coherent
allocator API (just like any other driver) and the reason we want this component
is because otherwise this abstraction layer would end up in every Rust driver
that needs the DMA coherent allocator as duplicated code, which for obvious
reasons isn't desirable.

Throughout this conversation I did not see technical arguments or concerns
against this, but I did recognize your opposition against Rust in the kernel
and cross-language projects.

Being a maintainer myself, I think it is outside the scope of a maintainer to
restrict the usage of a public kernel API for a certain entity arbitrarily and /
or by personal preference, which, as it appears to me, is the case here.

@Greg, @Linus: I believe this would be on your purview.

Please find the full thread in [1].

[1] https://lore.kernel.org/rust-for-linux/20250108135951.GA18074@lst.de/