linux-kernel - Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARrCVWSHobzF+FXKuD=fERBG7gmA7MfkRnnuDg55sTY2w@mail.gmail.com>
Date: Thu, 30 Jan 2025 08:52:59 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Kienan Stewart <kstewart@...icios.com>
Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, 
	Naveen N Rao <naveen@...nel.org>, Nicolas Schier <nicolas@...sle.org>, 
	Nathan Chancellor <nathan@...nel.org>, linuxppc-dev@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc
 crtsavres.o artifact

On Wed, Jan 29, 2025 at 12:53 AM Kienan Stewart <kstewart@...icios.com> wrote:
>
> Hi,
>
> I missed a few CCs, looping them in now. Apologies for the extra noise.
>
> thanks,
> kienan
>
> On 1/27/25 1:47 PM, Kienan Stewart wrote:
> > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b
> > ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts")
> > artifacts required for building out-of-tree kernel modules had
> > $(objtree) prepended to them to prepare for building in other
> > directories.
> >
> > When building external modules for powerpc,
> > arch/powerpc/lib/crtsavres.o is required for certain
> > configurations. This artifact is missing the prepended $(objtree).
> >
> > External modules may work around this omission for v6.13 by setting MO=$KDIR.
> >
> > Signed-off-by: Kienan Stewart <kstewart@...icios.com>

Good catch, this actually got broken by 13b25489b6f8.



Fixes: 13b25489b6f8 ("kbuild: change working directory to external
module directory with M=")
Acked-by: Masahiro Yamada <masahiroy@...nel.org>





> > ---
> >   arch/powerpc/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefile
> > @@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy)
> >   # There is a corresponding test in arch/powerpc/lib/Makefile
> >   KBUILD_LDFLAGS_MODULE += --save-restore-funcs
> >   else
> > -KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> > +KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o
> >   endif
> >
> >   ifdef CONFIG_CPU_LITTLE_ENDIAN
> >
> > ---
> > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> > change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83
> >
> > Best regards,
>
>


-- 
Best Regards
Masahiro Yamada