[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250129060534.GA29266@lst.de>
Date: Wed, 29 Jan 2025 07:05:34 +0100
From: Christoph Hellwig <hch@....de>
To: Daniel Wagner <wagi@...nel.org>
Cc: Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
Ming Lei <ming.lei@...hat.com>,
James Smart <james.smart@...adcom.com>,
Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH 1/3] nvme-tcp: rate limit error message in send path
On Tue, Jan 28, 2025 at 05:34:46PM +0100, Daniel Wagner wrote:
> If a lot of request are in the queue, this message is spamming the logs,
> thus rate limit it.
Are in the queue when what happens? Not that I'm against this,
but if we have a known condition where this error is printed a lot
we should probably skip it entirely for that?
Powered by blists - more mailing lists