linux-kernel - Re: [PATCH 2/3] alloc_tag: uninline code gated by mem_alloc_profiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250128190328.03a177d2@gandalf.local.home>
Date: Tue, 28 Jan 2025 19:03:28 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: Vlastimil Babka <vbabka@...e.cz>, akpm@...ux-foundation.org, Peter
 Zijlstra <peterz@...radead.org>, kent.overstreet@...ux.dev,
 yuzhao@...gle.com, minchan@...gle.com, shakeel.butt@...ux.dev,
 souravpanda@...gle.com, pasha.tatashin@...een.com, 00107082@....com,
 quic_zhenhuah@...cinc.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] alloc_tag: uninline code gated by
 mem_alloc_profiling_key in slab allocator

On Tue, 28 Jan 2025 15:43:13 -0800
Suren Baghdasaryan <surenb@...gle.com> wrote:

> > How slow is it to always do the call instead of inlining?  
> 
> Let's see... The additional overhead if we always call is:
> 
> Little core: 2.42%
> Middle core: 1.23%
> Big core: 0.66%
> 
> Not a huge deal because the overhead of memory profiling when enabled
> is much higher. So, maybe for simplicity I should indeed always call?

That's what I was thinking, unless the other maintainers are OK with this
special logic.

-- Steve