linux-kernel - Re: [PATCH 3/3] firmware: stratix10-svc: Add of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250129082714.22432-1-mahesh.rao@intel.com>
Date: Wed, 29 Jan 2025 16:27:14 +0800
From: Mahesh Rao <mahesh.rao@...el.com>
To: krzysztof.kozlowski@...aro.org
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dinguyen@...nel.org,
	hao.wu@...el.com,
	krzk+dt@...nel.org,
	linux-fpga@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mahesh.rao@...era.com,
	mahesh.rao@...el.com,
	mdf@...nel.org,
	robh@...nel.org,
	trix@...hat.com,
	yilun.xu@...el.com
Subject: Re: [PATCH 3/3] firmware: stratix10-svc: Add of_platform_default_populate()

Hi Krzysztof,
Thanks for Reviewing the patch.

On Thu, 23 Jan 2025 08:26:08 +0100, Krzysztof Kozlowski wrote:
> > Add of_platform_default_populate() to stratix10-svc driver as the
> > firmware/svc node was moved out of soc.
> > This fixes the failed probing of child drivers of svc node.
> >
> > Fixes: 23c3ebed382a ("arm64: dts: socfpga: agilex: move firmware out
> > of soc node")
> >
> 
> 
> There is never a blank line between tags. Use: `git log`
> 
> > Signed-off-by: Mahesh Rao <mahesh.rao@...el.com>

Understood, I will revise this in the next revision.

> 
> > ---
> >  drivers/firmware/stratix10-svc.c | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/firmware/stratix10-svc.c
> > b/drivers/firmware/stratix10-svc.c
> > index

> >  	platform_device_unregister(svc->stratix10_svc_rsu);
> >  err_free_kfifo:
> >  	kfifo_free(&controller->svc_fifo);
> 
> 
> You need to update remove() callback.
> 

Sure, I will add the changes in the next revision.

Best regards,
Mahesh Rao