linux-kernel - RE: [PATCH RFC net-next 1/2] net: pcs: xpcs: Add special code to operate in Microchip KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM3PR11MB8736F40CD4BE7FC3E04544E0ECEE2@DM3PR11MB8736.namprd11.prod.outlook.com>
Date: Wed, 29 Jan 2025 00:31:12 +0000
From: <Tristram.Ha@...rochip.com>
To: <olteanv@...il.com>
CC: <Woojung.Huh@...rochip.com>, <andrew@...n.ch>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <maxime.chevallier@...tlin.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <UNGLinuxDriver@...rochip.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RFC net-next 1/2] net: pcs: xpcs: Add special code to
 operate in Microchip KSZ9477 switch

> On Mon, Jan 27, 2025 at 07:32:25PM -0800, Tristram.Ha@...rochip.com wrote:
> > However SGMII mode in KSZ9477 has a bug in which the current speed
> > needs to be set in MII_BMCR to pass traffic.  The current driver code
> > does not do anything when link is up with auto-negotiation enabled, so
> > that code needs to be changed for KSZ9477.
> 
> Does this claimed SGMII bug have an erratum number like Microchip usually
> assign for something this serious? Is it something we can look up?

KSZ9477 errata module 7 indicates the MII_ADVERTISE register needs to be
set 0x01A0.  This is done with phylink_mii_c22_pcs_encode_advertisement()
but only for 1000BaseX mode.  I probably need to add that code in SGMII
configuration.  The default value of this register is 0x20.  This update
depends on SFP.  So far I did not find a SGMII SFP that requires this
setting.  This issue is more like the hardware did not set the default
value properly.

KSZ9477 errata module 8 indicates the MII_BMCR register needs to be
updated with the correct speed setting.