linux-kernel - Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <umk5gfo7iq7krppvqsal57hlzds26bdqd3g7kccjzuudjikdws@k2oknd6zx6g7>
Date: Wed, 29 Jan 2025 09:49:13 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Paul Moore <paul@...l-moore.com>
Cc: Matthew Wilcox <willy@...radead.org>, 
	Jani Nikula <jani.nikula@...el.com>, Ard Biesheuvel <ardb@...nel.org>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Thomas Weißschuh <linux@...ssschuh.net>, 
	Kees Cook <kees@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, linux-crypto@...r.kernel.org, 
	openipmi-developer@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	intel-xe@...ts.freedesktop.org, linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-raid@...r.kernel.org, linux-scsi@...r.kernel.org, linux-serial@...r.kernel.org, 
	xen-devel@...ts.xenproject.org, linux-aio@...ck.org, linux-fsdevel@...r.kernel.org, 
	netfs@...ts.linux.dev, codalist@...a.cs.cmu.edu, linux-mm@...ck.org, 
	linux-nfs@...r.kernel.org, ocfs2-devel@...ts.linux.dev, fsverity@...ts.linux.dev, 
	linux-xfs@...r.kernel.org, io-uring@...r.kernel.org, bpf@...r.kernel.org, 
	kexec@...ts.infradead.org, linux-trace-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org, apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org, 
	keyrings@...r.kernel.org, Song Liu <song@...nel.org>, 
	"Steven Rostedt (Google)" <rostedt@...dmis.org>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	"Darrick J. Wong" <djwong@...nel.org>, Corey Minyard <cminyard@...sta.com>
Subject: Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables
 where applicable

On Tue, Jan 28, 2025 at 10:43:10AM -0500, Paul Moore wrote:
> On Tue, Jan 28, 2025 at 6:22 AM Joel Granados <joel.granados@...nel.org> wrote:
> > On Mon, Jan 27, 2025 at 03:42:39PM +0000, Matthew Wilcox wrote:
> > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote:
> > > > You could have static const within functions too. You get the rodata
> > > > protection and function local scope, best of both worlds?
> > >
> > > timer_active is on the stack, so it can't be static const.
> > >
> > > Does this really need to be cc'd to such a wide distribution list?
> > That is a very good question. I removed 160 people from the original
> > e-mail and left the ones that where previously involved with this patch
> > and left all the lists for good measure. But it seems I can reduce it
> > even more.
> >
> > How about this: For these treewide efforts I just leave the people that
> > are/were involved in the series and add two lists: linux-kernel and
> > linux-hardening.
> >
> > Unless someone screams, I'll try this out on my next treewide.
> 
> I'm not screaming about it :) but anything that touches the LSM,
I'll consider it as a scream :) So I'll keep my previous approach of
leaving only personal mails that are involved, but leaving all the lists
that b4 suggests.

> SELinux, or audit code (or matches the regex in MAINTAINERS) I would
> prefer to see on the associated mailing list.

General comment sent to the void:
It is tricky to know exactly who wants to be informed of all this and
who thinks its useless. I think that if we want more focus it should
come from automated tools like b4. Maybe some string in MAINTAINERS
stating that the list should not be used in cases of tree-wide commits?

Best

-- 

Joel Granados