linux-kernel - Re: [PATCH 1/2] s390: fgraph: Fix to remove ftrace_test_recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36780a0c327fe6fe0fee1c05ba04368e46d30a37@linux.dev>
Date: Wed, 29 Jan 2025 00:36:40 +0000
From: "Ihor Solodrai" <ihor.solodrai@...ux.dev>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, "Steven Rostedt"
 <rostedt@...dmis.org>, "Heiko Carstens" <hca@...ux.ibm.com>, "Sven
 Schnelle" <svens@...ux.ibm.com>
Cc: "Jiri Olsa" <olsajiri@...il.com>, "Masami Hiramatsu"
 <mhiramat@...nel.org>, "Mark Rutland" <mark.rutland@....com>, "Vasily
 Gorbik" <gor@...ux.ibm.com>, "Alexander Gordeev"
 <agordeev@...ux.ibm.com>, "Christian Borntraeger"
 <borntraeger@...ux.ibm.com>, "Andrii Nakryiko"
 <andrii.nakryiko@...il.com>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-s390@...r.kernel.org, "bpf"
 <bpf@...r.kernel.org>
Subject: Re: [PATCH 1/2] s390: fgraph: Fix to remove
 ftrace_test_recursion_trylock()

January 28, 2025 at 7:29 AM, "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:



> 
> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Fix to remove ftrace_test_recursion_trylock() from ftrace_graph_func()
> 
> because commit d576aec24df9 ("fgraph: Get ftrace recursion lock in
> 
> function_graph_enter") has been moved it to function_graph_enter_regs()
> 
> already.
> 
> Reported-by: Jiri Olsa <olsajiri@...il.com>
> 
> Closes: https://lore.kernel.org/all/Z5O0shrdgeExZ2kF@krava/
> 
> Fixes: d576aec24df9 ("fgraph: Get ftrace recursion lock in function_graph_enter")
> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Tested-by: Jiri Olsa <jolsa@...nel.org>
> 
> [...]

Hi Masami,

Can confirm this patch fixes missed/kprobe_recursion BPF selftests on s390x:
https://github.com/kernel-patches/vmtest/actions/runs/13021621468/job/36324248903

Tested-by: Ihor Solodrai <ihor.solodrai@...ux.dev>

Thanks!