linux-kernel - Re: [PATCH v5 2/5] arm64: dts: agilex: add soc0 label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3bb46ce-d79c-4d57-93ba-90bdeb98658f@kernel.org>
Date: Wed, 29 Jan 2025 10:45:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...ux.intel.com>, lpieralisi@...nel.org,
 kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org,
 bhelgaas@...gle.com, krzk+dt@...nel.org, conor+dt@...nel.org,
 dinguyen@...nel.org, joyce.ooi@...el.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: matthew.gerlach@...era.com, peter.colberg@...era.com
Subject: Re: [PATCH v5 2/5] arm64: dts: agilex: add soc0 label

On 27/01/2025 18:35, Matthew Gerlach wrote:
> Add a label to the soc@0 device tree node.
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> ---
> v3:
>  - Remove accepted patches from patch set.
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..144fe74e929e 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -152,7 +152,7 @@ usbphy0: usbphy {
>  		compatible = "usb-nop-xceiv";
>  	};
>  
> -	soc@0 {
> +	soc0: soc@0 {
This shouldn't be a separate commit, really. It serves no purpose to
just add the label. Just like you do not add just a define in a driver
without its user. Label like this itself is pointless. It's useful for
something, so this should be squashed.

Best regards,
Krzysztof