linux-kernel - Re: [PATCH 04/16] ALSA: ac97: convert timeouts to secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o6zq6jg2.wl-tiwai@suse.de>
Date: Wed, 29 Jan 2025 10:46:53 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,	Yaron Avizrat
 <yaron.avizrat@...el.com>,	Oded Gabbay <ogabbay@...nel.org>,	Julia Lawall
 <Julia.Lawall@...ia.fr>,	Nicolas Palix <nicolas.palix@...g.fr>,	James Smart
 <james.smart@...adcom.com>,	Dick Kennedy <dick.kennedy@...adcom.com>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,	Jaroslav Kysela
 <perex@...ex.cz>,	Takashi Iwai <tiwai@...e.com>,	Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>,	David Sterba <dsterba@...e.com>,	Ilya
 Dryomov <idryomov@...il.com>,	Dongsheng Yang <dongsheng.yang@...ystack.cn>,
	Jens Axboe <axboe@...nel.dk>,	Xiubo Li <xiubli@...hat.com>,	Damien Le Moal
 <dlemoal@...nel.org>,	Niklas Cassel <cassel@...nel.org>,	Carlos Maiolino
 <cem@...nel.org>,	"Darrick J. Wong" <djwong@...nel.org>,	Sebastian Reichel
 <sre@...nel.org>,	Keith Busch <kbusch@...nel.org>,	Christoph Hellwig
 <hch@....de>,	Sagi Grimberg <sagi@...mberg.me>,	Frank Li
 <Frank.Li@....com>,	Mark Brown <broonie@...nel.org>,	Shawn Guo
 <shawnguo@...nel.org>,	Sascha Hauer <s.hauer@...gutronix.de>,	Pengutronix
 Kernel Team <kernel@...gutronix.de>,	Fabio Estevam <festevam@...il.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>,	Hans de Goede
 <hdegoede@...hat.com>,	Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>,	Henrique de Moraes Holschuh
 <hmh@....eng.br>,	Selvin Xavier <selvin.xavier@...adcom.com>,	Kalesh AP
 <kalesh-anakkur.purayil@...adcom.com>,	Jason Gunthorpe <jgg@...pe.ca>,	Leon
 Romanovsky <leon@...nel.org>,	cocci@...ia.fr,
	linux-kernel@...r.kernel.org,	linux-scsi@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,	linux-sound@...r.kernel.org,
	linux-btrfs@...r.kernel.org,	ceph-devel@...r.kernel.org,
	linux-block@...r.kernel.org,	linux-ide@...r.kernel.org,
	linux-xfs@...r.kernel.org,	linux-pm@...r.kernel.org,
	linux-nvme@...ts.infradead.org,	linux-spi@...r.kernel.org,
	imx@...ts.linux.dev,	linux-arm-kernel@...ts.infradead.org,
	platform-driver-x86@...r.kernel.org,	ibm-acpi-devel@...ts.sourceforge.net,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH 04/16] ALSA: ac97: convert timeouts to secs_to_jiffies()

On Tue, 28 Jan 2025 19:21:49 +0100,
Easwar Hariharan wrote:
> 
> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies().  As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
> 
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
> 
> @depends on patch@
> expression E;
> @@
> 
> -msecs_to_jiffies
> +secs_to_jiffies
> (E
> - * \( 1000 \| MSEC_PER_SEC \)
> )
> 
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>

Acked-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi


> ---
>  sound/pci/ac97/ac97_codec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index 6e710dce5c6068ec20c2da751b6f5372ad1df211..88ac37739b7653f69af430dd0163f5ab4ddf0d0c 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -2461,8 +2461,7 @@ int snd_ac97_update_power(struct snd_ac97 *ac97, int reg, int powerup)
>  		 * (for avoiding loud click noises for many (OSS) apps
>  		 *  that open/close frequently)
>  		 */
> -		schedule_delayed_work(&ac97->power_work,
> -				      msecs_to_jiffies(power_save * 1000));
> +		schedule_delayed_work(&ac97->power_work, secs_to_jiffies(power_save));
>  	else {
>  		cancel_delayed_work(&ac97->power_work);
>  		update_power_regs(ac97);
> 
> -- 
> 2.43.0
>