linux-kernel - Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5oAcugIxU6zdROD@louis-chauvet-laptop>
Date: Wed, 29 Jan 2025 11:18:26 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Paz Zcharya <pazz@...omium.org>
Cc: Sean Paul <seanpaul@...gle.com>, Drew Davenport <ddavenport@...gle.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	David Airlie <airlied@...il.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Melissa Wen <melissa.srw@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

On 28/01/25 - 15:08, Paz Zcharya wrote:
> On Tue, Jan 28, 2025 at 11:04:33AM +0100, Louis Chauvet wrote:
> > On 27/01/25 - 23:59, Paz Zcharya wrote:
> > > Add support for pixel format ABGR8888, which is the default format
> > > on Android devices. This will allow us to use VKMS as the default
> > > display driver in Android Emulator (Cuttlefish) and increase VKMS
> > > adoption.
> > > 
> > > Changes in v2:
> > > - Rebased on top of tip of tree because it has been 3 months.
> > > - No functional changes.
> > > 
> > > Signed-off-by: Paz Zcharya <pazz@...gle.com>
> > 
> > Hi Paz,
> > 
> > Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
> > 
> > When applying a patch I got a small warning about a missmatch between your 
> > author email and the Signed-off-by:
> > 
> > 	-:106: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Paz Zcharya <pazz@...omium.org>' != 'Signed-off-by: Paz Zcharya <pazz@...gle.com>'
> > 
> > I can fix it for you by adding a Author: / changing the Sign-of-by before 
> > applying on drm-misc-next.
> > 
> > What mail do you want to use? pazz@...gle.com or pazz@...omium.org?
> > 
> > Thanks!
> > Louis Chauvet
> 
> Thank you for the quick review, Louis!
> 
> Let's use pazz@...gle.com.
> I apologize about the mistake -- I'll make sure to fix that in the
> future.

And I just noticed that "changes in v2" is in the commit log. It should 
not be there.

To add a changelog, you must put it after ---, so in your case your commit 
should be something like:

	drm/vkms: Add support for ABGR8888 pixel format

	Add support for [...] adoption.

	Signed-off-by: Paz Zcharya <pazz@...gle.com>

	---

	Changes in v2:
	[...]

Can you send a "real" v2 with the correct commit message and the correct 
author?

If you don't know it, you can use b4[1] to help you manage your series and 
iterations.

[1]:https://b4.docs.kernel.org/en/latest/

 
> Greatly appericiate your help!
> 
> Thanks a lot,
> Paz
>