linux-kernel - RE: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002f01db722e$fccac1d0$f6604570$@samsung.com>
Date: Wed, 29 Jan 2025 14:50:02 +0530
From: "Swathi K S" <swathi.ks@...sung.com>
To: "'Russell King \(Oracle\)'" <linux@...linux.org.uk>
Cc: <krzk@...nel.org>, <robh@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<conor+dt@...nel.org>, <richardcochran@...il.com>,
	<mcoquelin.stm32@...il.com>, <andrew@...n.ch>, <alim.akhtar@...sung.com>,
	<linux-fsd@...la.com>, <netdev@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<alexandre.torgue@...s.st.com>, <peppe.cavallaro@...com>,
	<joabreu@...opsys.com>, <rcsekar@...sung.com>, <ssiddha@...la.com>,
	<jayati.sahu@...sung.com>, <pankaj.dubey@...sung.com>,
	<ravi.patel@...sung.com>, <gost.dev@...sung.com>
Subject: RE: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support



> -----Original Message-----
> From: Russell King (Oracle) <linux@...linux.org.uk>
> Sent: 28 January 2025 20:30
> To: Swathi K S <swathi.ks@...sung.com>
> Cc: krzk@...nel.org; robh@...nel.org; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> conor+dt@...nel.org; richardcochran@...il.com;
> mcoquelin.stm32@...il.com; andrew@...n.ch; alim.akhtar@...sung.com;
> linux-fsd@...la.com; netdev@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com;
> linux-arm-kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org;
> alexandre.torgue@...s.st.com; peppe.cavallaro@...com;
> joabreu@...opsys.com; rcsekar@...sung.com; ssiddha@...la.com;
> jayati.sahu@...sung.com; pankaj.dubey@...sung.com;
> ravi.patel@...sung.com; gost.dev@...sung.com
> Subject: Re: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
> 
> On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:
> > +struct fsd_eqos_plat_data {
> > +	struct clk_bulk_data *clks;
> > +	int num_clks;
> > +	struct device *dev;
> 
> You only write to this, so it serves no purpose in this patch. Please
remove.

Hi Russell, 
Thanks for reviewing.
Will remove  struct device *dev from struct fsd_eqos_plat_data

-Swathi

> 
> Thanks.
> 
> --
> RMK's Patch system: https://protect2.fireeye.com/v1/url?k=8378c0b8-
> e2f3d582-83794bf7-74fe4860008a-3788c416dc857e61&q=1&e=4d22ed29-
> 449b-46e6-90ba-
> 9b1470e01ecb&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F
> patches%2F
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!