lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250129111406.GW20626@gate.crashing.org>
Date: Wed, 29 Jan 2025 05:14:06 -0600
From: Segher Boessenkool <segher@...nel.crashing.org>
To: Julian Vetter <julian@...er-limits.org>
Cc: Arnd Bergmann <arnd@...db.de>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Naveen N Rao <naveen@...nel.org>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote:
> Remove the eieio() calls in IO functions for PowerPC. While other
> architectures permit prefetching, combining, and reordering, the eieio()
> calls on PowerPC prevent such optimizations.

Yes, and it is crucial to prevent combining, it is part of the semantics
of these functions.  This is a much bigger problem on PowerPC than on
architectures which optimise memory accesses much less.  So most other
archs can get away with it much easier (but it is still completely wrong
there).

You are keeping the trap;isync things, which a) have a way bigger
performance impact, and b) are merely a debugging aid (if some i/o
access kills the system, it will be clear where that came from).  And
that isn't even the biggest thing of course, there is a heavyweight
sync in there as well.  Is there any benefit to this patch, or is it
only sabotage?


Segher

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ