linux-kernel - Re: [PATCH 14/16] platform/x86/amd/pmf: convert timeouts to secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8207616-6079-be0d-d482-6577616a4cc7@linux.intel.com>
Date: Wed, 29 Jan 2025 15:12:49 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
cc: Andrew Morton <akpm@...ux-foundation.org>, 
    Yaron Avizrat <yaron.avizrat@...el.com>, Oded Gabbay <ogabbay@...nel.org>, 
    Julia Lawall <Julia.Lawall@...ia.fr>, 
    Nicolas Palix <nicolas.palix@...g.fr>, 
    James Smart <james.smart@...adcom.com>, 
    Dick Kennedy <dick.kennedy@...adcom.com>, 
    "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, 
    "Martin K. Petersen" <martin.petersen@...cle.com>, 
    Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
    Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, 
    David Sterba <dsterba@...e.com>, Ilya Dryomov <idryomov@...il.com>, 
    Dongsheng Yang <dongsheng.yang@...ystack.cn>, Jens Axboe <axboe@...nel.dk>, 
    Xiubo Li <xiubli@...hat.com>, Damien Le Moal <dlemoal@...nel.org>, 
    Niklas Cassel <cassel@...nel.org>, Carlos Maiolino <cem@...nel.org>, 
    "Darrick J. Wong" <djwong@...nel.org>, Sebastian Reichel <sre@...nel.org>, 
    Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, 
    Sagi Grimberg <sagi@...mberg.me>, Frank Li <Frank.Li@....com>, 
    Mark Brown <broonie@...nel.org>, Shawn Guo <shawnguo@...nel.org>, 
    Sascha Hauer <s.hauer@...gutronix.de>, 
    Pengutronix Kernel Team <kernel@...gutronix.de>, 
    Fabio Estevam <festevam@...il.com>, 
    Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Henrique de Moraes Holschuh <hmh@....eng.br>, 
    Selvin Xavier <selvin.xavier@...adcom.com>, 
    Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, 
    Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, 
    cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>, 
    linux-scsi@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
    linux-sound@...r.kernel.org, linux-btrfs@...r.kernel.org, 
    ceph-devel@...r.kernel.org, linux-block@...r.kernel.org, 
    linux-ide@...r.kernel.org, linux-xfs@...r.kernel.org, 
    linux-pm@...r.kernel.org, linux-nvme@...ts.infradead.org, 
    linux-spi@...r.kernel.org, imx@...ts.linux.dev, 
    linux-arm-kernel@...ts.infradead.org, platform-driver-x86@...r.kernel.org, 
    ibm-acpi-devel@...ts.sourceforge.net, linux-rdma@...r.kernel.org
Subject: Re: [PATCH 14/16] platform/x86/amd/pmf: convert timeouts to
 secs_to_jiffies()

On Tue, 28 Jan 2025, Easwar Hariharan wrote:

> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies().  As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
> 
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
> 
> @depends on patch@
> expression E;
> @@
> 
> -msecs_to_jiffies
> +secs_to_jiffies
> (E
> - * \( 1000 \| MSEC_PER_SEC \)
> )
> 
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> ---
>  drivers/platform/x86/amd/pmf/acpi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c
> index dd5780a1d06e1dc979fcff5bafd6729bc4937eab..6b7effe80b78b7389b320ee65fa5d2373f782a2f 100644
> --- a/drivers/platform/x86/amd/pmf/acpi.c
> +++ b/drivers/platform/x86/amd/pmf/acpi.c
> @@ -220,7 +220,8 @@ static void apmf_sbios_heartbeat_notify(struct work_struct *work)
>  	if (!info)
>  		return;
>  
> -	schedule_delayed_work(&dev->heart_beat, msecs_to_jiffies(dev->hb_interval * 1000));
> +	schedule_delayed_work(&dev->heart_beat,
> +			      secs_to_jiffies(dev->hb_interval));
>  	kfree(info);
>  }

Hi,

So you made the line shorter but still added the newline char for some 
reason even if the original didn't have one?? Please don't enforce 80 
chars limit with patches like this.

-- 
 i.